Unsave Feast Recipes from Feast Web Nudges - #16645
Open
andresilva-guardian wants to merge 1 commit into
Open
Conversation
andresilva-guardian
added
the
feature
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
andresilva-guardian
changed the title
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:09f73a532609fad809f5d400a2b4aa39d47201f45f677dd82cc3d43a51813cb4"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-afs-unsave-feast-recipe-from-the-web"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-30577"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-033efe7224209a19317c69d291e606a81ff75a83"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/deployTools --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds an unsave action for Feast recipes saved from web articles.
DELETEsaved-from-web client request with bearer authentication.503responses with exponential backoff.UNSAVE_FEAST_RECIPE_BY_IDmessage handler and unsave analytics event.Why?
Readers need to be able to remove recipes they have previously saved from an article, using the same Feast banner integration that supports saving.
How has this change been tested?
Automated tests
savedFromWeb.test.ts204 No Contentresponse.503response.BrazeBannersSystem.test.tsxBoth focused suites pass: 26 tests.
Manual testing
Not performed.
Screenshots
No visual changes.